-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UserId module to export user ids as eids with pbjs.getUserIdsAsEids() #5108
UserId module to export user ids as eids with pbjs.getUserIdsAsEids() #5108
Conversation
@pm-harshad-mane Do we need a docs PR to list this new function on the Prebid API? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small fix, then the rest looks good
Hello @idettman , |
Hello @idettman , |
…prebid#5108) * added support for pubcommon, digitrust, id5id * added support for IdentityLink * changed the source for id5 * added unit test cases * changed source param for identityLink * exposing a new function to export userIds in Eids format * added test cases for functions that export userIds * added the missing semicolon :-)
Type of change
Description of change
UserId module to export user ids as eids with pbjs.getUserIdsAsEids()